Add create TRSP solver function - #312
Open
jared321 wants to merge 19 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 93.24% 93.74% +0.49%
==========================================
Files 106 111 +5
Lines 4977 5257 +280
==========================================
+ Hits 4641 4928 +287
+ Misses 336 329 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
It's only for test/debug purposes. Alert users to this if they still want to use it.
For both Python and MATLAB, there are tests that hit the MINQ5 evaluation budget. Neither detects problems that are unbounded from below. Also, make docs free from actual number index for the spsolvers and remove whitespace that make flake8 sad.
More clearly delineate where subsolver-specific exit flags stop and the POUNDERS exit flag starts. At present, this does not impose any strong standard on the subsolvers nor try to homogenize them in this new intermediate layer of code.
jared321
changed the title
jared321
requested review from
jmlarson1 and
mmenickelly
and removed request for
mmenickelly
July 21, 2026 19:16
10 tasks
Passing locally when called directly. Called by nocoverage tox task.
This fixes the TRSP solver interface for the outputs. Note that the MINQ wrapper had to be updated to satisfy that interface. As a result, POUNDERS no longer needs to squeeze the solution vector. Tests passing.
A port of the Python version of the test. Align the variable names to those declared in the interface by create_trsp_solver.py. Test passing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an intermediate step performed for both Python and MATLAB. We should expect bitwise identical POUNDERS results compared to benchmarks.
PR Self-review
spsolverset to 4